Skip to content

Comments

feat: add tfds dataset format and bridge v2 dataset#400

Merged
kwangneuraco merged 1 commit intodevelopfrom
feat/add_tfds_bridge_dataset
Feb 19, 2026
Merged

feat: add tfds dataset format and bridge v2 dataset#400
kwangneuraco merged 1 commit intodevelopfrom
feat/add_tfds_bridge_dataset

Conversation

@kwangneuraco
Copy link
Contributor

  • Add tfds support, which is a alive dataformat and slightly better than rlds (stopped maintaining)
  • add bridge v2 dataset import config
  • add tests relevant and lerobot test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

PR source branch is valid

  • Source: feat/add_tfds_bridge_dataset
  • Target: develop

@kwangneuraco kwangneuraco added the version:minor non-breaking feature updates, new functions or endpoints label Feb 13, 2026
@github-actions
Copy link
Contributor

Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking.

@kwangneuraco kwangneuraco force-pushed the feat/add_tfds_bridge_dataset branch from 90100d4 to 9270d2a Compare February 13, 2026 12:15
@sdas-neuraco
Copy link
Contributor

Split into two PRs with Lerobot tests in a separate one. We should back test the existing Datasets to check nothing is broken with RLDS. comments included from @ypang-neuraco

@kwangneuraco kwangneuraco force-pushed the feat/add_tfds_bridge_dataset branch from 9270d2a to 22bbf62 Compare February 13, 2026 13:37
Copy link
Contributor

@ypang-neuraco ypang-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if you can merge the _record_step of TFDS and RLDS. It seems to be the same to me.

@kwangneuraco kwangneuraco force-pushed the feat/add_tfds_bridge_dataset branch 4 times, most recently from db4978c to e3f12f5 Compare February 18, 2026 16:40
Copy link
Contributor

@ypang-neuraco ypang-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM \w comments. Please remove the old code for RLDS importer if it is not used anymore.

Comment on lines 430 to 435
elif (
self.allow_mapping_name_fallback
and isinstance(source, dict)
and item.name in source
):
source_data = source[item.name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the fallback on item name, users should fix the source name if it is incorrect.

@kwangneuraco kwangneuraco force-pushed the feat/add_tfds_bridge_dataset branch from 075cdb8 to b978b2f Compare February 19, 2026 11:21
@kwangneuraco kwangneuraco force-pushed the feat/add_tfds_bridge_dataset branch from b978b2f to 8979a41 Compare February 19, 2026 11:47
@kwangneuraco kwangneuraco merged commit 13dd73a into develop Feb 19, 2026
8 checks passed
@kwangneuraco kwangneuraco deleted the feat/add_tfds_bridge_dataset branch February 19, 2026 12:11
aditya-neuraco pushed a commit that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:minor non-breaking feature updates, new functions or endpoints

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants