feat: add tfds dataset format and bridge v2 dataset#400
Open
kwangneuraco wants to merge 1 commit intodevelopfrom
Open
feat: add tfds dataset format and bridge v2 dataset#400kwangneuraco wants to merge 1 commit intodevelopfrom
kwangneuraco wants to merge 1 commit intodevelopfrom
Conversation
Contributor
kwangneuraco
commented
Feb 13, 2026
kwangneuraco
commented
- Add tfds support, which is a alive dataformat and slightly better than rlds (stopped maintaining)
- add bridge v2 dataset import config
- add tests relevant and lerobot test
Contributor
|
✅ PR source branch is valid
|
kwangneuraco
added
the
version:minor
Contributor
|
Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking. |
kwangneuraco
force-pushed
the
feat/add_tfds_bridge_dataset
branch
from
90100d4 to
9270d2a
Compare
Contributor
|
Split into two PRs with Lerobot tests in a separate one. We should back test the existing Datasets to check nothing is broken with RLDS. comments included from @ypang-neuraco |
kwangneuraco
force-pushed
the
feat/add_tfds_bridge_dataset
branch
from
9270d2a to
22bbf62
Compare
ypang-neuraco
requested changes
Feb 13, 2026
Contributor
ypang-neuraco
left a comment
ypang-neuraco
left a comment
There was a problem hiding this comment.
Please check if you can merge the _record_step of TFDS and RLDS. It seems to be the same to me.
kwangneuraco
force-pushed
the
feat/add_tfds_bridge_dataset
branch
3 times, most recently
from
41b0031 to
db4978c
Compare
… dataset upload and all relevant tests
kwangneuraco
force-pushed
the
feat/add_tfds_bridge_dataset
branch
from
db4978c to
e3f12f5
Compare
ypang-neuraco
approved these changes
Feb 18, 2026
Contributor
ypang-neuraco
left a comment
ypang-neuraco
left a comment
There was a problem hiding this comment.
LGTM \w comments. Please remove the old code for RLDS importer if it is not used anymore.
Comment on lines
+430
to
+435
| elif ( | ||
| self.allow_mapping_name_fallback | ||
| and isinstance(source, dict) | ||
| and item.name in source | ||
| ): | ||
| source_data = source[item.name] |
Contributor
There was a problem hiding this comment.
Please remove the fallback on item name, users should fix the source name if it is incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.